Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-428: Apply Security to Different Features #222

Closed
wants to merge 1 commit into from

Conversation

curtisupshall
Copy link
Contributor

Overview

Links to Jira tickets

Description of relevant changes

TBD.

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@curtisupshall curtisupshall changed the base branch from dataset_security_feature to dev January 4, 2024 19:29
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 594 lines in your changes are missing coverage. Please review.

Comparison is base (c955dec) 68.71% compared to head (364863a) 62.08%.
Report is 193 commits behind head on dataset_security_feature.

Files Patch % Lines
api/src/repositories/search-index-respository.ts 44.64% 31 Missing ⚠️
...issions/components/ManageSecurityReasonsDialog.tsx 0.00% 31 Missing ⚠️
app/src/components/security/SecurityRuleForm.tsx 0.00% 30 Missing ⚠️
...atures/submissions/components/SubmissionHeader.tsx 0.00% 28 Missing ⚠️
app/src/components/security/SecuritiesDialog.tsx 0.00% 27 Missing ⚠️
app/src/contexts/submissionContext.tsx 6.89% 27 Missing ⚠️
app/src/guards/RouteGuards.tsx 0.00% 21 Missing ⚠️
api/src/paths/administrative/security/apply.ts 0.00% 17 Missing ⚠️
api/src/paths/submission/search-idx.ts 0.00% 17 Missing ⚠️
.../dashboard/components/ReviewedSubmissionsTable.tsx 5.55% 17 Missing ⚠️
... and 63 more
Additional details and impacted files
@@                     Coverage Diff                      @@
##           dataset_security_feature     #222      +/-   ##
============================================================
- Coverage                     68.71%   62.08%   -6.64%     
============================================================
  Files                           215      263      +48     
  Lines                          6146     7152    +1006     
  Branches                        945     1007      +62     
============================================================
+ Hits                           4223     4440     +217     
- Misses                         1700     2472     +772     
- Partials                        223      240      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curtisupshall curtisupshall changed the base branch from dev to dataset_security_feature January 4, 2024 19:29
@curtisupshall curtisupshall deleted the SIMSBIOHUB-428 branch January 4, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant