Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIFixes: UI Fixes/Improvements #226

Merged
merged 5 commits into from
Jan 8, 2024
Merged

UIFixes: UI Fixes/Improvements #226

merged 5 commits into from
Jan 8, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jan 5, 2024

Links to Jira Tickets

None

Description of Changes

Fixing sort menu issues

Testing Notes

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c21daaf) 62.08% compared to head (4676025) 62.10%.

Files Patch % Lines
.../features/submissions/list/SubmissionsListPage.tsx 0.00% 1 Missing ⚠️
...tures/submissions/list/SubmissionsListSortMenu.tsx 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #226      +/-   ##
==========================================
+ Coverage   62.08%   62.10%   +0.02%     
==========================================
  Files         263      262       -1     
  Lines        7152     7157       +5     
  Branches     1007     1009       +2     
==========================================
+ Hits         4440     4445       +5     
  Misses       2472     2472              
  Partials      240      240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura changed the title BugFixes: UI Fixes/Improvements UIFixes: UI Fixes/Improvements Jan 5, 2024
KjartanE
KjartanE previously approved these changes Jan 5, 2024
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸 tested locally!

@KjartanE KjartanE self-assigned this Jan 5, 2024
al-rosenthal
al-rosenthal previously approved these changes Jan 5, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️

@jeznorth jeznorth dismissed stale reviews from al-rosenthal and KjartanE via 9a4a3b8 January 5, 2024 19:25
@NickPhura NickPhura requested a review from MacQSL January 5, 2024 20:45
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@jeznorth jeznorth merged commit 773ce1e into dev Jan 8, 2024
21 checks passed
KjartanE pushed a commit that referenced this pull request Jan 8, 2024
Fixing the sort menu interfaces for submissions.

---------

Co-authored-by: jeznorth <[email protected]>
@NickPhura NickPhura deleted the sort-menu-fixes-2 branch September 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants