SIMSBIOHUB-428: Apply Security to Different Features

[curtisupshall]

Overview

Apply security rules to selected features.

Links to Jira tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-428

Testing

You should be able to apply and remove multiple security rules to any number of selected features.

Description of relevant changes

• Updated endpoints and service and repo methods to support applying security to selected features.
• Refactored the frontend to support selecting features, applying security rules, and to see already applied security rules.

Removed endpoints

Endpoint	Purpose
.../security/apply.ts	Was used to apply and override security rules to features. This has been replaced.
.../security/category/fetch.ts	Was used to fetch all security rule rules with their associated. This has been replaced.
.../security/remove.ts	Was used to remove security rules from a set of features. Has been superseded by .../security/rules.
.../security/index	Was originally used to get all security rules. Because we don't currently have a use for getting rules without their categories, this endpoint has been removed in favor of .../security/rules.

Moved endpoints

Endpoint	Purpose
...security/category/index → .../security/categories.ts	Used to list all active security categories

New endpoints

Endpoint	Purpose
.../security/rules	Used to fetch all security rule rules with their associated
.../security/submission/{submissionId}.ts	Used to list already-applied security rules, and to apply/remove security for any number of features belonging to the given submission

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohub-platform-app-227-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohub-platform-api-227-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/a0ec71-dev/pods?name=227

[codecov]

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (4573d87) 0.00% compared to head (d8798c3) 62.44%.

Files	Patch %	Lines
app/src/components/security/SecurityRuleForm.tsx	0.00%	53 Missing ⚠️
...ministrative/security/submission/{submissionId}.ts	0.00%	35 Missing ⚠️
...p/src/features/submissions/AdminSubmissionPage.tsx	0.00%	16 Missing ⚠️
...ures/submissions/components/SubmissionDataGrid.tsx	0.00%	15 Missing ⚠️
api/src/repositories/security-repository.ts	64.70%	6 Missing ⚠️
...submissions/components/SubmissionHeaderToolbar.tsx	0.00%	5 Missing ⚠️
app/src/hooks/api/useSecurityApi.ts	37.50%	5 Missing ⚠️
app/src/components/security/SecuritiesDialog.tsx	0.00%	4 Missing ⚠️
...src/components/security/SecurityRuleActionCard.tsx	0.00%	4 Missing ⚠️
api/src/services/security-service.ts	81.25%	2 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@           Coverage Diff            @@
##           dev     #227       +/-   ##
========================================
+ Coverage     0   62.44%   +62.44%     
========================================
  Files        0      263      +263     
  Lines        0     7294     +7294     
  Branches     0     1029     +1029     
========================================
+ Hits         0     4555     +4555     
- Misses       0     2494     +2494     
- Partials     0      245      +245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohub-platform-app-227-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohub-platform-api-227-a0ec71-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/a0ec71-dev/pods?name=227

[al-rosenthal]

Ran this locally and it works great. Couple of nit picks but overall solid

[sonarqubecloud]

Quality Gate failed

Failed conditions

7.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[al-rosenthal]

😎

[KjartanE]

Tested locally, works great. Just couple questions about service functions. 🐈