Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-426-2: Calculate and display submission regions #232

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

SIMSBIOHUB-426

Description of Changes

  • Added migrations for region_lookup and submission_regions
  • Added seed files for existing regions (taken from SIMS)
  • Modified Submission fetch to include regions
  • Modified intake to include region calculations

Testing Notes

  • Run both SIMS and BioHub locally
  • Create a Project/ Survey in SIMS
  • Publish that Survey
  • In BioHub navigate to Submissions tab and see regions on new submission

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a305328) 62.44% compared to head (6228e28) 62.30%.

Files Patch % Lines
api/src/repositories/region-repository.ts 77.77% 3 Missing and 1 partial ⚠️
...dashboard/components/PublishedSubmissionsTable.tsx 0.00% 1 Missing ⚠️
.../dashboard/components/ReviewedSubmissionsTable.tsx 0.00% 1 Missing ⚠️
...ashboard/components/UnreviewedSubmissionsTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #232      +/-   ##
==========================================
- Coverage   62.44%   62.30%   -0.15%     
==========================================
  Files         263      265       +2     
  Lines        7294     7319      +25     
  Branches     1029     1033       +4     
==========================================
+ Hits         4555     4560       +5     
- Misses       2494     2513      +19     
- Partials      245      246       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.9% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, works as expected!

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gud!

@al-rosenthal al-rosenthal merged commit 9084dec into dev Jan 17, 2024
19 of 21 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-426-2 branch January 17, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants