-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-426-2: Calculate and display submission regions #232
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #232 +/- ##
==========================================
- Coverage 62.44% 62.30% -0.15%
==========================================
Files 263 265 +2
Lines 7294 7319 +25
Branches 1029 1033 +4
==========================================
+ Hits 4555 4560 +5
- Misses 2494 2513 +19
- Partials 245 246 +1 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions 5.9% Duplication on New Code (required ≤ 3%) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local, works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks gud!
Links to Jira Tickets
SIMSBIOHUB-426
Description of Changes
region_lookup
andsubmission_regions
Testing Notes