Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-455 - ITIS Taxon cache + Taxon Alias tables #234

Merged
merged 9 commits into from
Jan 24, 2024
Merged

SIMSBIOHUB-455 - ITIS Taxon cache + Taxon Alias tables #234

merged 9 commits into from
Jan 24, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Jan 22, 2024

Links to Jira Tickets

Ticket-455

Description of Changes

  • New Taxon ITIS cache table
  • New Taxon Alias table
  • New Language Lookup table
  • New Taxon Alias Origin table

Questions

  1. Should we have soft delete unique indexes on scientific_name / bc_taxon_code and itis_tsn or just scientific_name?

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b42969b) 62.82% compared to head (434856a) 62.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #234   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files         265      265           
  Lines        7402     7402           
  Branches     1039     1039           
=======================================
  Hits         4650     4650           
  Misses       2496     2496           
  Partials      256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

al-rosenthal
al-rosenthal previously approved these changes Jan 24, 2024
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

curtisupshall
curtisupshall previously approved these changes Jan 24, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickPhura NickPhura changed the title 455 - ITIS Taxon cache + Taxon Alias tables SIMSBIOHUB-455 - ITIS Taxon cache + Taxon Alias tables Jan 24, 2024
@MacQSL MacQSL dismissed stale reviews from curtisupshall and al-rosenthal via 434856a January 24, 2024 21:36
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧈

@MacQSL MacQSL merged commit 4df6210 into dev Jan 24, 2024
21 checks passed
@MacQSL MacQSL deleted the 455 branch January 24, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants