SIMSBIOHUB-449: Upgrade to Postgres 17 #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
NickPhura
force-pushed
the
SIMSBIOHUB-449-test
branch
from
73c1ea7 to
b7f9472
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1428 +/- ##
=======================================
Coverage 46.08% 46.08%
=======================================
Files 910 910
Lines 23752 23752
Branches 3500 3500
=======================================
Hits 10947 10947
Misses 12189 12189
Partials 616 616 ☔ View full report in Codecov by Sentry. |
NickPhura
force-pushed
the
SIMSBIOHUB-449-test
branch
2 times, most recently
from
18c823f to
890817a
Compare
- Wrap most instances of "system_user" in double quotes, as it is not a reserved word in postgres. - Add migration to drop biohub_dapi_v1 schema - Disable static deploy db setup step
NickPhura
force-pushed
the
SIMSBIOHUB-449-test
branch
from
b6fdb71 to
0214854
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-449
Description of Changes
Upgrade local and remote Postgres versions from 12.5 to 17.
system_userin double quotes (as it is a reserved word and using it unwrapped will fail in the database.system_userwhen it is used in a knex query builder.Cleanup
Testing Notes
Database builds/deploys as usual.
API works as usual.
Note:
Migration Plan
I've included all of the steps in a comment in the Jira ticket.
The main thing to be aware of is that this PR disables the dev/test/prod database knex migration step, so that I can run it manually one time during this version upgrade (we can re-enable it afterwards).