Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Support Page #1445

Open
wants to merge 56 commits into
base: dev
Choose a base branch
from
Open

Create Support Page #1445

wants to merge 56 commits into from

Conversation

LouisThedroux
Copy link
Collaborator

Description of Changes

Initial page creation, text content is still currently being worked on but there is prelimiary placeholders in there and is subject to change. Underlying functionalty and layout needs to be reviewed and improved upon before going any further on the functionalty side of things.

  • Overview Section: A clear navigation panel to explore support topics.
  • Main Content: Comprehensive descriptions and guidance for categories like General Information, SIMS Structure, Foundational Data, Observations, Animals, Telemetry, and Data Standards.
  • Accordions: Expandable sections for FAQs and detailed guidance within each category.

@LouisThedroux LouisThedroux added Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (ef532a3) to head (3403bc7).

Files with missing lines Patch % Lines
...atures/support/components/AccordionSupportCard.tsx 0.00% 44 Missing ⚠️
app/src/features/support/SupportPage.tsx 0.00% 23 Missing ⚠️
app/src/features/support/data/dataStandards.tsx 0.00% 2 Missing ⚠️
app/src/features/support/data/general.tsx 0.00% 2 Missing ⚠️
app/src/features/support/data/observations.tsx 0.00% 2 Missing ⚠️
app/src/features/support/data/animals.tsx 0.00% 1 Missing ⚠️
app/src/features/support/data/contact.tsx 0.00% 1 Missing ⚠️
app/src/features/support/data/dataMap.tsx 0.00% 1 Missing ⚠️
app/src/features/support/data/foundation.tsx 0.00% 1 Missing ⚠️
app/src/features/support/data/structure.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1445      +/-   ##
==========================================
- Coverage   46.07%   45.92%   -0.16%     
==========================================
  Files         911      923      +12     
  Lines       23792    23866      +74     
  Branches     3507     3530      +23     
==========================================
- Hits        10963    10960       -3     
- Misses      12211    12288      +77     
  Partials      618      618              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc
Copy link
Collaborator

Check out the "106 issues" in the Quality Gate comment on this PR page. Sonar cloud identifies patterns in the code that are considered bad, like using the index as the key prop within map(), or missing the key prop (in which case React cannot reliably distinguish between UI elements when trying to smartly re-render the component upon some change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR should not be merged Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants