Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18449 - GP/SP registration modify #582

Merged
merged 24 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/components/Registration/HelpContactUs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@
import { Component, Vue } from 'vue-property-decorator'
import RegistriesContactInfo from '@/components/common/RegistriesContactInfo.vue'
import FirmContactInfo from '@/components/common/FirmContactInfo.vue'
import { Getter } from 'pinia-class'
import { useStore } from '@/store/store'

@Component({
components: {
Expand All @@ -63,7 +61,6 @@ import { useStore } from '@/store/store'
})
export default class HelpContactUs extends Vue {
helpToggle = false
@Getter(useStore) isTypeFirm!: boolean
}
</script>

Expand Down
23 changes: 8 additions & 15 deletions src/components/common/FirmContactInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,29 +29,22 @@
</ul>
</template>

<script lang="ts">
import { Component, Vue } from 'vue-property-decorator'
JazzarKarim marked this conversation as resolved.
Show resolved Hide resolved

@Component({})
export default class RegistriesContactInfo extends Vue {}
</script>

<style lang="scss" scoped>
@import '@/assets/styles/theme.scss';

.contact-container {
font-size: $px-15;
color: $gray7;
display: flex;
}

.contact-icon {
flex: 0 0 1.375rem;
justify-content: flex-start;
color: $app-dk-blue;
}
.contact-icon {
flex: 0 0 1.375rem;
justify-content: flex-start;
color: $app-dk-blue;
}

.contact-value {
flex: 1 1;
}
.contact-value {
flex: 1 1;
}
</style>
3 changes: 2 additions & 1 deletion tests/unit/HelpContactUs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ describe('HelpBusinessNumber', () => {
expect(wrapper.find('.help-header h2').text()).toBe('Contact BC Registries')

// verify paragraph
expect(wrapper.find('p').text()).toContain('If you require further assistance adding a business, please contact us.')
expect(wrapper.find('p').text())
.toContain('If you require further assistance adding a business, please contact us.')

// verify contact info component
expect(wrapper.findComponent(FirmContactInfo).exists()).toBe(true)
Expand Down
18 changes: 12 additions & 6 deletions tests/unit/RegAddEditOrgPerson.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,10 @@ describe('Registration Add/Edit Org/Person component', () => {
store.stateModel.tombstone.keycloakRoles = ['staff']
const wrapper = createComponent(validProprietorOrg, -1, null)

expect(wrapper.findAll('.business-lookup-article label').at(0).text()).toContain('Business or Corporation Registered in B.C')
expect(wrapper.findAll('.business-lookup-article label').at(1).text()).toContain('Business or Corporation Name or Incorporation Number')
expect(wrapper.findAll('.business-lookup-article label').at(0).text())
.toContain('Business or Corporation Registered in B.C')
expect(wrapper.findAll('.business-lookup-article label').at(1).text())
.toContain('Business or Corporation Name or Incorporation Number')
expect(wrapper.findAll('.business-lookup-article p').at(0).text()).toContain('the Proprietor')

wrapper.destroy()
Expand All @@ -392,7 +394,8 @@ describe('Registration Add/Edit Org/Person component', () => {
const wrapper = createComponent(validProprietorOrg, -1, null)

expect(wrapper.find('.business-lookup-article label').text()).toContain('Business')
expect(wrapper.findAll('.business-lookup-article p').at(0).text()).toContain('Enter an existing B.C. business as the proprietor')
expect(wrapper.findAll('.business-lookup-article p').at(0).text())
.toContain('Enter an existing B.C. business as the proprietor')

wrapper.destroy()
})
Expand Down Expand Up @@ -450,8 +453,10 @@ describe('Registration Add/Edit Org/Person component', () => {
store.stateModel.tombstone.keycloakRoles = ['staff']
const wrapper = createComponent(validPartnerOrg, -1, null)

expect(wrapper.findAll('.business-lookup-article label').at(0).text()).toContain('Business or Corporation Registered in B.C')
expect(wrapper.findAll('.business-lookup-article label').at(1).text()).toContain('Business or Corporation Name or Incorporation Number')
expect(wrapper.findAll('.business-lookup-article label').at(0).text())
.toContain('Business or Corporation Registered in B.C')
expect(wrapper.findAll('.business-lookup-article label').at(1).text())
.toContain('Business or Corporation Name or Incorporation Number')
expect(wrapper.findAll('.business-lookup-article p').at(0).text()).toContain('a partner')

wrapper.destroy()
Expand All @@ -462,7 +467,8 @@ describe('Registration Add/Edit Org/Person component', () => {
const wrapper = createComponent(validPartnerOrg, -1, null)

expect(wrapper.find('.business-lookup-article label').text()).toContain('Business')
expect(wrapper.findAll('.business-lookup-article p').at(0).text()).toContain('Enter an existing B.C. business as a partner')
expect(wrapper.findAll('.business-lookup-article p').at(0).text())
.toContain('Enter an existing B.C. business as a partner')

wrapper.destroy()
})
Expand Down
Loading