22846 - show resolution dates in amalgamations

[ketaki-deodhar]

Issue #: /bcgov/entity#22846

Description of changes:

• fetch resolutions
• show resolution dates on summary page
• save resolution dates in filing
• WIP - add more unit tests

Short form amalgamation (Horizontal):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[ketaki-deodhar]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-create-dev--pr-745-9wwaez00.web.app

Short form amalgamation example: https://business-create-dev--pr-745-9wwaez00.web.app/amalg-short-review-confirm?id=TQ61BRdHHk&accountid=3040

[ArwenQin]

Looks good!

[severinbeauvais]

I think the font size should be 14px, same as the other content in the table.

Also, the label colour should be #212529 and the value colour should be #495057.

You can confirm with Jacqueline if you want.

[severinbeauvais]

While you're working on this component, Jacqueline would like the Share Structure table headers to have the same format as the People and Roles table headers (#212529, bold, 14px). Can you make this change or should that be another ticket? Update: done, thanks!

[ketaki-deodhar]

While you're working on this component, Jacqueline would like the Share Structure table headers to have the same format as the People and Roles table headers (#212529, bold, 14px). Can you make this change or should that be another ticket?

No need for another ticket. I will do it here

[ketaki-deodhar]

used hide-default-header to apply custom style.

[ketaki-deodhar]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-create-dev--pr-745-9wwaez00.web.app

[ketaki-deodhar]

As this is a common component, this is how it looks when just a list:
Before/DEV:

After:

When in edit mode:
Before/DEV:

After:

[severinbeauvais]

Awesome! Looks great.

[ketaki-deodhar]

I think the font size should be 14px, same as the other content in the table.

Also, the label colour should be #212529 and the value colour should be #495057.

You can confirm with Jacqueline if you want.

Also, Jacqueline to take a look at this

[ketaki-deodhar]

Jacqueline took a look at this and suggested to change the color for values

[jacqueline-williams-549]

I think the font size should be 14px, same as the other content in the table.
Also, the label colour should be #212529 and the value colour should be #495057.
You can confirm with Jacqueline if you want.

Also, Jacqueline to take a look at this

Reviewed with Ketaki and getting back to her about suggestion about language

[severinbeauvais]

LGTM. Remember to update the app version.