23514 Remove testing workaround (status) #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed cont in state work-around
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-748-4yts8jys.web.app SB says, try these:
|
severinbeauvais
commented
Oct 15, 2024
| // *** TODO: remove after testing | ||
| if (draftFiling.header.status === FilingStatus.CHANGE_REQUESTED) { | ||
| this.setFilingStatus(FilingStatus.APPROVED) | ||
| } |
There was a problem hiding this comment.
This was a simple work-around so that "Change Requested" continuation filings would appear as Approved and therefore show steps 1-4 (instead of just step 0 aka authorization step).
Note that it's not possible to display Approved filings in the Todo List, because the BE currently sends them to the Filer. The new BE code is expected to be merged today. At that point, we should be able to see Approved continuation filing in the Todo List, and resume them in Create UI to complete steps 1-4, as per the new flow.
vysakh-menon-aot
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#23514
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).