Skip to content

Commit

Permalink
Merge pull request #607 from Rajandeep98/25095_header_date
Browse files Browse the repository at this point in the history
25095 process header date
  • Loading branch information
Rajandeep98 authored Jan 3, 2025
2 parents f7950db + 14deab3 commit 7ece621
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ContactPointIF, NaicsIF, NameRequestIF, SpecialResolutionIF } from '@bc
export interface CorrectionInformationIF extends CoopAlterationIF, SpecialResolutionIF {
comment: string // max 4096 characters
correctedFilingId: number
correctedFilingDate?: string // API format
correctedFilingDate?: string // filing date is in YYYY-MM-DD format
correctedFilingType: FilingTypes
type: CorrectionErrorTypes
legalType?: CorpTypeCd
Expand Down
11 changes: 5 additions & 6 deletions src/mixins/filing-template-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export default class FilingTemplateMixin extends DateMixin {
},
correctedFilingId: this.getCorrectedFilingId,
correctedFilingType: this.getCorrectedFilingType,
correctedFilingDate: this.correctedFilingDate,
correctedFilingDate: this.getCorrectedFilingDate,
comment: `${this.defaultCorrectionDetailComment}\n${this.getDetailComment}`,
contactPoint: this.getContactPoint,
nameRequest: {
Expand Down Expand Up @@ -1455,15 +1455,14 @@ export default class FilingTemplateMixin extends DateMixin {
/** The default (hard-coded first line) correction detail comment. */
public get defaultCorrectionDetailComment (): string {
const correctedFilingName = FilingTypeToName(this.getCorrectedFilingType)
return `Correction for ${correctedFilingName} filed on ${this.correctedFilingDate}`
return `Correction for ${correctedFilingName} filed on ${this.getCorrectedFilingDate}`
}

// FUTURE: probably don't need this becayse Corrected Filing Date is already YYYY-MM-DD
/** The corrected filing date as YYYY-MM-DD. */
private get correctedFilingDate (): string {
const date = this.apiToDate(this.getCorrectedFilingDate)
return this.dateToYyyyMmDd(date)
}
// private get correctedFilingDate (): string {
// return this.getCorrectedFilingDate
// }

/** The Contact Point object. */
private get getContactPoint (): ContactPointIF {
Expand Down

0 comments on commit 7ece621

Please sign in to comment.