Skip to content

Commit

Permalink
Removed obsolete code (#258)
Browse files Browse the repository at this point in the history
  • Loading branch information
cameron-eyds authored Apr 14, 2022
1 parent 0bbb3a0 commit f556d7e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 19 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "2.1.6",
"version": "2.1.7",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
20 changes: 3 additions & 17 deletions src/components/common/PeopleAndRoles/CurrentDirectors.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<v-simple-table class="director-table section-container">
<!-- List Display Section -->
<thead v-if="currentDirectors.length > 0">
<thead v-if="getPeopleAndRoles.length > 0">
<!-- List Headers -->
<tr class="director-list-header pb-3">
<th v-for="(title, index) in tableHeaders" :key="index" class="px-0">
Expand All @@ -27,7 +27,7 @@
<!-- List Content -->
<tr
class="director-content py-3"
v-for="(orgPerson, index) in currentDirectors"
v-for="(orgPerson, index) in getPeopleAndRoles"
:key="`director:${index}`"
>
<!-- Name + Badge -->
Expand Down Expand Up @@ -56,7 +56,7 @@

<!-- Appointment Date -->
<td class="px-0">
<span class="director-detail">{{ orgPerson.roles[0].appointmentDate }} to Current</span>
<span class="director-detail">{{ orgPerson.appointmentDate }} to Current</span>
</td>
</tr>
</tbody>
Expand Down Expand Up @@ -87,20 +87,6 @@ export default class CurrentDirectors extends Mixins(CommonMixin) {
/** Headers for the person table. */
readonly tableHeaders = ['Name', 'Mailing Address', 'Delivery Address', 'Effective Dates']
/**
* Returns the current directors from the people and roles.
* @returns array of directors
*/
private get currentDirectors () : OrgPersonIF[] {
const directors = this.getPeopleAndRoles
.filter(people => people.roles.some(role =>
role.roleType === RoleTypes.DIRECTOR && !role.cessationDate))
for (const director of directors) {
director.roles = director.roles.filter(role => role.roleType === RoleTypes.DIRECTOR)
}
return directors
}
}
</script>

Expand Down

0 comments on commit f556d7e

Please sign in to comment.