25294 - Submit NoW for Bootstrap Filing (#712)

* handle bootstrap filing properties Signed-off-by: Qin <[email protected]> * update unit tests Signed-off-by: Qin <[email protected]> * update package version Signed-off-by: Qin <[email protected]> * remove not needed import Signed-off-by: Qin <[email protected]> * update legal name handling Signed-off-by: Qin <[email protected]> * update fallback to null Signed-off-by: Qin <[email protected]> * update fallback to null 2 Signed-off-by: Qin <[email protected]> * update default undefined value Signed-off-by: Qin <[email protected]> * update default undefined value 2 Signed-off-by: Qin <[email protected]> --------- Signed-off-by: Qin <[email protected]>
bcgov · Jan 17, 2025 · 5cf66ef · 5cf66ef
1 parent b81ec72
commit 5cf66ef
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-filings-ui",
-  "version": "7.4.13",
+  "version": "7.4.14",
   "private": true,
   "appName": "Filings UI",
   "sbcName": "SBC Common Components",

diff --git a/src/App.vue b/src/App.vue
@@ -168,7 +168,8 @@ import {
 import { BreadcrumbIF } from '@bcrs-shared-components/interfaces'
 import { FilingStatus, NameRequestStates, NigsMessage, Routes } from '@/enums'
 import { FilingTypes } from '@bcrs-shared-components/enums'
-import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd, GetCorpFullDescription, GetCorpNumberedDescription }
+  from '@bcrs-shared-components/corp-type-module'
 import { SessionStorageKeys } from 'sbc-common-components/src/util/constants'
 import { useBusinessStore, useConfigurationStore, useFilingHistoryListStore, useRootStore } from './stores'
 
@@ -371,6 +372,7 @@ export default class App extends Mixins(
   @Action(useBusinessStore) setLegalName!: (x: string) => Promise<void>
   @Action(useBusinessStore) setLegalType!: (x: CorpTypeCd) => Promise<void>
   @Action(useBusinessStore) setIdentifier!: (x: string) => Promise<void>
+  @Action(useBusinessStore) setFoundingDate!: (x: string) => Promise<void>
 
   @Action(useFilingHistoryListStore) loadFilings!: (x: string) => Promise<void>
   @Action(useFilingHistoryListStore) setFilings!: (x: ApiFilingIF[]) => void
@@ -624,6 +626,12 @@ export default class App extends Mixins(
     const filing = response?.filing
     const filingName = filing.header?.name as FilingTypes
     const status = filing.header.status as FilingStatus
+    const foundingDate = filing.header?.effectiveDate || null // use the FE date as the founding date
+    const email =
+        filing.incorporationApplication?.contactPoint?.email ||
+        filing.amalgamationApplication?.contactPoint?.email ||
+        filing.continuationIn?.contactPoint?.email ||
+        filing.registration?.contactPoint?.email || null
 
     if (!filing || !filing.business || !filing.header || !filingName || !status) {
       throw new Error(`Invalid boostrap filing - missing required property = ${filing}`)
@@ -656,12 +664,17 @@ export default class App extends Mixins(
     this.setIdentifier(this.tempRegNumber)
     this.setLegalType(legalType)
     this.setGoodStanding(true) // draft apps are always in good standing
+    this.setFoundingDate(foundingDate)
+    this.setBusinessEmail(email)
 
     // save local NR Number if present
     if (nameRequest.nrNumber) this.localNrNumber = nameRequest.nrNumber
 
     // store Legal Name if present
-    if (nameRequest.legalName) this.setLegalName(nameRequest.legalName)
+    // special case to identify numbered amalgamations
+    if (filingName === FilingTypes.AMALGAMATION_APPLICATION) {
+      this.setLegalName(nameRequest.legalName || 'Numbered Amalgamated Company')
+    } else { this.setLegalName(nameRequest.legalName || GetCorpNumberedDescription(this.getLegalType)) }
 
     // store the bootstrap item in the right list
     if (this.isBootstrapTodo) this.storeBootstrapTodo(response)

diff --git a/src/views/AmalgamationOut.vue b/src/views/AmalgamationOut.vue
@@ -795,7 +795,7 @@ export default class AmalgamationOut extends Mixins(CommonMixin, DateMixin, Fili
       header: {
         name: FilingTypes.AMALGAMATION_OUT,
         certifiedBy: this.certifiedBy || '',
-        email: this.getBusinessEmail || '',
+        email: this.getBusinessEmail || undefined,
         date: this.getCurrentDate // NB: API will reassign this date according to its clock
       }
     }

diff --git a/src/views/ConsentAmalgamationOut.vue b/src/views/ConsentAmalgamationOut.vue
@@ -721,7 +721,7 @@ export default class ConsentAmalgamationOut extends Mixins(CommonMixin, DateMixi
       header: {
         name: FilingTypes.CONSENT_AMALGAMATION_OUT,
         certifiedBy: this.certifiedBy || '',
-        email: this.getBusinessEmail || '',
+        email: this.getBusinessEmail || undefined,
         date: this.getCurrentDate // NB: API will reassign this date according to its clock
       }
     }

diff --git a/src/views/ConsentContinuationOut.vue b/src/views/ConsentContinuationOut.vue
@@ -721,7 +721,7 @@ export default class ConsentContinuationOut extends Mixins(CommonMixin, DateMixi
       header: {
         name: FilingTypes.CONSENT_CONTINUATION_OUT,
         certifiedBy: this.certifiedBy || '',
-        email: this.getBusinessEmail || '',
+        email: this.getBusinessEmail || undefined,
         date: this.getCurrentDate // NB: API will reassign this date according to its clock
       }
     }

diff --git a/src/views/ContinuationOut.vue b/src/views/ContinuationOut.vue
@@ -725,7 +725,7 @@ export default class ContinuationOut extends Mixins(CommonMixin, DateMixin, Fili
       header: {
         name: FilingTypes.CONTINUATION_OUT,
         certifiedBy: this.certifiedBy || '',
-        email: this.getBusinessEmail || '',
+        email: this.getBusinessEmail || undefined,
         date: this.getCurrentDate // NB: API will reassign this date according to its clock
       }
     }

diff --git a/src/views/NoticeOfWithdrawal.vue b/src/views/NoticeOfWithdrawal.vue
@@ -729,7 +729,7 @@ export default class NoticeOfWithdrawal extends Mixins(CommonMixin, DateMixin, F
         header: {
           name: FilingTypes.NOTICE_OF_WITHDRAWAL,
           certifiedBy: this.certifiedBy || '',
-          email: this.getBusinessEmail || '',
+          email: this.getBusinessEmail || undefined,
           date: this.getCurrentDate // NB: API will reassign this date according to its clock
         }
       }
@@ -761,7 +761,7 @@ export default class NoticeOfWithdrawal extends Mixins(CommonMixin, DateMixin, F
 
       const business: any = {
         business: {
-          foundingDate: this.dateToApi(this.getFoundingDate),
+          foundingDate: this.dateToApi(this.getFoundingDate) || undefined,
           identifier: this.getIdentifier,
           legalName: this.getLegalName,
           legalType: this.getLegalType

diff --git a/tests/unit/App.spec.ts b/tests/unit/App.spec.ts
@@ -2319,7 +2319,7 @@ describe('App as a draft numbered regular amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationTodo).toBe(true)
     expect(rootStore.isBootstrapTodo).toBe(true)
 
@@ -2533,7 +2533,7 @@ describe('App as a completed regular amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationFiling).toBe(true)
     expect(rootStore.isBootstrapFiling).toBe(true)
 
@@ -2632,7 +2632,7 @@ describe('App as a draft horizontal amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationTodo).toBe(true)
     expect(rootStore.isBootstrapTodo).toBe(true)
 
@@ -2736,7 +2736,7 @@ describe('App as a completed horizontal amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationFiling).toBe(true)
     expect(rootStore.isBootstrapFiling).toBe(true)
 
@@ -2835,7 +2835,7 @@ describe('App as a draft vertical amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationTodo).toBe(true)
     expect(rootStore.isBootstrapTodo).toBe(true)
 
@@ -2939,7 +2939,7 @@ describe('App as a completed vertical amalgamation application', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityBcCompany).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Amalgamated Company')
     expect(rootStore.isAmalgamationFiling).toBe(true)
     expect(rootStore.isBootstrapFiling).toBe(true)
 
@@ -3033,7 +3033,7 @@ describe('App as a draft numbered continuation in', () => {
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityContinueIn).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Limited Company')
     expect(rootStore.isContinuationInTodo).toBe(true)
     expect(rootStore.isBootstrapTodo).toBe(true)
 
@@ -3130,13 +3130,13 @@ describe('App as a completed continuation in', () => {
     wrapper.destroy()
   })
 
-  it('fetches continuation in  filing properly', () => {
+  it('fetches continuation in filing properly', () => {
     expect(rootStore.getNameRequest).toBeNull()
     expect(rootStore.isContinuationInFiling).toBe(true)
     expect(businessStore.getIdentifier).toBe('T123456789')
     expect(businessStore.isEntityContinueIn).toBe(true)
     expect(businessStore.isGoodStanding).toBe(true)
-    expect(businessStore.getLegalName).toBeNull()
+    expect(businessStore.getLegalName).toBe('Numbered Limited Company')
     expect(rootStore.isContinuationInFiling).toBe(true)
     expect(rootStore.isBootstrapFiling).toBe(true)