Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reg2 mock data #2627

Open
10 of 14 tasks
BCerki opened this issue Dec 19, 2024 · 3 comments
Open
10 of 14 tasks

Improve reg2 mock data #2627

BCerki opened this issue Dec 19, 2024 · 3 comments
Assignees

Comments

@BCerki
Copy link
Contributor

BCerki commented Dec 19, 2024

Describe the task

We separated reg1 and reg2 mock data as part of #2222. Reg1 mock data should stay untouched to allow reg1 e2e tests to pass. Reg2 mock data, however, could use some improvements. It's hard to test transfers right now because we don't have enough records and/or they're contradictory.

Acceptance Criteria

  • Operation and OperationDesignatedOperatorTimeline model data should match (Operation has a pk to operator in both, and they're not consistent currently)
  • operation status and purpose should make sense (e.g., a mock operation has to be registered before it can have a purpose or regulated products, and only certain purposes have products)
  • All operators (except one for testing, name is something like "Alpha Industries - no operation) should have at least one Operation
  • All SFO operations (again, except one for testing, put something like -- no facility) should have one facility
  • All LFO operations (except one) should have at least two facilities
  • At least one operator should have parent operators (put -- Has ParENT Operators in the legal_name)
  • At least one operator should have partner operators (put -- Has ParTNER Operators in the legal_name)
  • Only give about half the operations a BORO ID (so we can test creating them), and if they have an ID, status must be operation.status must be registered
  • Only give half the facilities a BCGHG ID (so we can test creating them)
  • It is apparent from the operation name whether it is an SFO or LFO & whether it is registered
  • - [ ] Reg1 shouldn't have the Operation statuses of Registered, Transferred, Closed, or Temporarily Shutdown. When we tried to remove them from the reg1 mock data, the e2e tests failed. This was not reproducible locally, so first step to debugging this is modifying CI to get the playwright report so we can see what's going on.

Definition of Done

  • first
  • second
  • third

Additional context

  • Add any other context about the task here.
  • Or here
@BCerki
Copy link
Contributor Author

BCerki commented Dec 19, 2024

@dleard , do you want to add anything to the AC here?

@BCerki BCerki mentioned this issue Dec 19, 2024
@dleard
Copy link
Contributor

dleard commented Dec 19, 2024

I added one AC to the end about the operation names

@fviduya
Copy link

fviduya commented Dec 27, 2024

I've pushed the changes for the following:

9c6b398

  1. All SFO operations (again, except one for testing, put something like -- no facility) should have one facility
  2. All LFO operations (except one) should have at least two facilities
  3. At least one operator should have parent operators (put -- Has ParENT Operators in the legal_name)
  4. At least one operator should have partner operators (put -- Has ParTNER Operators in the legal_name)

393e9f8

  1. Only give about half the operations a BORO ID (so we can test creating them), and if they have an ID, status must be operation.status must be registered
  2. Only give half the facilities a BCGHG ID (so we can test creating them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants