-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test data #2620
Test data #2620
Conversation
961c670
to
1abc736
Compare
@@ -0,0 +1,236 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this is in v1
directory, but facilities are only relevant to Reg 2. Is this an oopsie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! There's a few others I can delete too, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might make reg1 e2e run faster too 👀
"bcghg_id": "23219990013", | ||
"created_at": "2024-1-20T15:27:00.000Z", | ||
"regulated_products": [1, 2, 3, 4], | ||
"status": "Transferred", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to have the "Transferred", "Closed", "Temporarily Shutdown", "Registered" statuses for v1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reg1 e2e tests do appear to be looking for those reg2 statuses, because CI fails when I take them out (and the code snippet below is maybe relevant?). I'll see if I can get @shon-button 's help figuring out where the failing assertions are, but if it's not straightforward, are you okay with me leaving these statuses in for this PR, and I'll add an AC about getting rid of them to #2627 ?
In /home/briannacerkiewicz/cas-registration/bciers/apps/registration1/e2e/poms/operations.ts:
expectedValues = [
OperationStatus.PENDING,
OperationStatus.APPROVED,
OperationStatus.DECLINED,
OperationStatus.CHANGES_REQUESTED,
OperationStatus.REGISTERED,
// Below values are not possible in Registration1
OperationStatus.CLOSED,
OperationStatus.TEMPORARILY_SHUTDOWN,
OperationStatus.TRANSFERRED,
bc_obps/Makefile
Outdated
@@ -92,6 +92,11 @@ superuser: ## create a superuser | |||
superuser: | |||
$(POETRY_RUN) python $(MANAGE_PY) create_superuser | |||
|
|||
loadfixtures_v1: ## add all registration fixture files to the db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by the naming conventions - is loadfixtures_v1
for Reg1 and loadfixtures
for Reg2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll make a comment and add some docs. This is to match how we've done the nx apps and the endpoints (so when we delete reg1 we're just left with reg instead of reg2, v2, etc.)
82826d7
to
7a65cc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Thanks for doing this Bri - it will help out a lot of people! :D
a14e0d2
to
220956b
Compare
Prep for #2222 . It's really hard to test reg2 db changes when we still have to keep the reg1 e2e tests running, and having both reg1 and reg2 stuff in the app is v confusing for testers and POs.
This PR:
make
commands refer to the original load fixture command, so no changes needed. All the model test fixtures also refer to the original directory so also no changes needed