Chore/365 django rls #2558
Draft
Chore/365 django rls #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with connection.cursor() as cursor: | ||
| cursor.execute("select current_setting('my.guid', true)") | ||
| x = cursor.fetchone() | ||
| print("GUID: ", x) |
There was a problem hiding this comment.
Is this print and the one after it for debugging purposes?
There was a problem hiding this comment.
I think keeping this middleware in the RLS app would be better.
bc_obps/rls/models.py
Outdated
bc_obps/rls/admin.py
Outdated
bc_obps/rls/utils.py
Outdated
Comment on lines
1
to
15
| class RlsRoles: | ||
| INDUSTRY_USER = "industry_user" | ||
| CAS_DIRECTOR = "cas_director" | ||
| CAS_ADMIN = "cas_admin" | ||
| CAS_ANALYST = "cas_analyst" | ||
| CAS_PENDING = "cas_pending" | ||
| CAS_VIEW_ONLY = "cas_view_only" | ||
| ALL_ROLES = 'industry_user, cas_director, cas_admin, cas_analyst, cas_pending, cas_view_only' | ||
|
|
||
|
|
||
| class RlsOperations: | ||
| SELECT = "select" | ||
| UPDATE = "update" | ||
| INSERT = "insert" | ||
| DELETE = "delete" |
There was a problem hiding this comment.
nit: suggest moving these to an enums.py and make them Enum
| if auth_header: | ||
| user_guid = UUID(json.loads(auth_header).get('user_guid'), version=4) | ||
| with connection.cursor() as cursor: | ||
| cursor.execute(f'SET my.guid = "{user_guid}" ') |
There was a problem hiding this comment.
Based on this statement it would be better to use placeholders to prevent SQL injection.
cursor.execute('SET my.guid = %s', [str(user_guid)])
dleard
commented
Jan 2, 2025
| def revoke_all_privileges(self): | ||
| with connection.cursor() as cursor: | ||
| cursor.execute(f'drop owned by {RlsRoles.ALL_ROLES}') | ||
| cursor.execute(f'grant usage on schema erc to {RlsRoles.ALL_ROLES}') |
There was a problem hiding this comment.
add usage on schema common as well
dleard
commented
Jan 2, 2025
bc_obps/rls/utils.py
Outdated
| self.schema = schema | ||
|
|
||
| def apply_policy(self, cursor): # type: ignore | ||
| execute_string = ( |
There was a problem hiding this comment.
use parameterized queries for all "execute string" calls
Signed-off-by: SeSo <[email protected]>
This was referenced Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged, for example only
Django - RLS proof of concept work.
Instructions in docs/rls_demo_instructions.md file