289 allocation of emissions bugs

[shon-button]

✏️ Notes

• This PR addresses bugs/tech debt from Feat/287 allocation of emissions #2553
• The issue "Save'" and "Save and Continue" buttons do the same thing (which bypasses the 100% allocation check) was introduced in 392 button tech debt #2519...and is
  Fixed in reporting buttons fixes #2567 (also applied to this branch):

🐛 Issues addressed:

Backend:

• Records are being saved to the report_emission_allocation table in the database when the allocated value is 0.
• Carry the emission category Ids in the schema & use them in the service
• (new) Update reporting.models.report_product_emission_allocation\allocated_quantity field max_digits from 10 to 20

Frontend:

• Carry the emission category Ids in form data as hidden fields (and use them in the payload)
• The details box when methodology is other is too small & the font is different
• Field Totals in tCO2e\Total emissions attributable for reporting is of inconsistent width with the rest of the page.
• (new) Category sections display header emission_category_name

🔬 Local Testing:

1. From terminal command, start the api server:

cd bc_obps
make reset_db
make run

2. From terminal command, start the app development server:

cd bciers && yarn dev-all

1. Navigate to http://localhost:3000
2. Click button "Log in with Business BCeID"
3. Navigate to http://localhost:3000/reporting/reports
4. On row Operation 3, click button Start
5. Complete the report pages until http://localhost:3000/reporting/reports/3/facilities/f486f2fb-62ed-438d-bb3e-0819b51e3aff/allocation-of-emissions
   Expected results:

• Allocation of Emissions page displays under step Report Information, task Allocation of Emissions
  
• Category product names display as title for each emission allocation section
• Products emissions reported on form Production Data display as expected in product category Total Emissions
  
• Totals in tCO2e\Total emissions attributable for reporting displays total as expected
• Button Save is enable
• Button Save and Continue is disabled
• Message displays All emissions must be allocated to 100% before saving and continuing
  

6. Allocate some emissions across category products
   Expected results:

• Allocation divisions and totlas are reflected as expected in Totals in tCO2e
  

7. Complete required fields, click Save
   Expected results:

• POST request is successful
• Page does not route to another page

8. Enter all emission allocations
   Expected results:

• Button Save and Continue is enabled
• Message does not display All emissions must be allocated to 100% before saving and continuing

9. Click Button Save and Continue
   Expected results:

• POST request is successful and page routes to Additional Reporting Data
  

[dleard]

Nice work! This makes things much more smooth & no extraneous data is getting into the database.

One thing I'd check with PO / BA is the behaviour of the "Save" button when 100% of emissions are not yet allocated. There is a message at the bottom that says you cannot "save & continue" without 100% allocation, which is good & that button is greyed out. However, the "Save" button looks live but when clicked, nothing gets saved. If the preference of the PO/BA is to not allow saving data at all until 100% of emissions are allocated then this button should also be greyed out, if they want to be able to save the data as-is at that point, then we'll need to wire that button to actually save when clicked.

^ That can be handled in another ticket when we get clarity on what the expectation is there around saving data when 100% of emissions have not been allocated.
Screenshot:

[dleard]

left over debugging line

[dleard]

Oops, I just went ahead and merged it immediately after approval. My bad. I'll just take this out in my current PR

[shon-button]

Nice work! This makes things much more smooth & no extraneous data is getting into the database.

One thing I'd check with PO / BA is the behaviour of the "Save" button when 100% of emissions are not yet allocated. There is a message at the bottom that says you cannot "save & continue" without 100% allocation, which is good & that button is greyed out. However, the "Save" button looks live but when clicked, nothing gets saved. If the preference of the PO/BA is to not allow saving data at all until 100% of emissions are allocated then this button should also be greyed out, if they want to be able to save the data as-is at that point, then we'll need to wire that button to actually save when clicked.

^ That can be handled in another ticket when we get clarity on what the expectation is there around saving data when 100% of emissions have not been allocated. Screenshot:

@dleard

For "However, the "Save" button looks live but when clicked, nothing gets saved" did you complete the required field Methodology? If not then Save will trigger the field validation errors; otherwise; the data should save, as it did for me (according to the test steps).

[dleard]

Ahh, that might have been it. I do forget to update that field sometimes and jump right into allocating. I'll check it again during our QA session this afternoon, thanks!