Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/456 operation representative #2628

Closed
wants to merge 8 commits into from
Closed

Chore/456 operation representative #2628

wants to merge 8 commits into from

Conversation

ayeshmcg
Copy link
Contributor

Card: bcgov/cas-reporting#456
Changes:-

  • Added a model report_operation_representative
  • Updated schema
  • modified create-report and get-report
  • updated operation_representative from string field to multiselect

@ayeshmcg
Copy link
Contributor Author

ayeshmcg commented Dec 19, 2024 •
edited by shon-button
Loading

@shon-button Creating this draft PR

@shon-button shon-button force-pushed the chore/456-operation-representative branch from 8ba9038 to 85c16ad Compare December 20, 2024 14:02
@shon-button shon-button marked this pull request as ready for review December 20, 2024 15:50
@shon-button shon-button force-pushed the chore/456-operation-representative branch from c7c2986 to 6973136 Compare December 20, 2024 16:24
@shon-button shon-button force-pushed the chore/456-operation-representative branch from 6973136 to e610b24 Compare December 20, 2024 17:20
@shon-button
Copy link
Contributor

@ayeshmcg

Done:

  • Fixed schema for operation_representative
  • Cleanup of form
  • Updated vitests
  • Updated endpoint test GET

To Do:

  • POST endpoint
  • POST endpoint tests
  • Suggestion: The router should navigate to the continueUrl only when the onSubmit function resolves with a truthy response

@ayeshmcg ayeshmcg force-pushed the chore/456-operation-representative branch from 3cefcd9 to 31296a2 Compare January 14, 2025 15:43
@ayeshmcg ayeshmcg closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayeshmcg @shon-button