Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2627 improve mock data #2636

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

2627 improve mock data #2636

wants to merge 9 commits into from

Conversation

BCerki
Copy link
Contributor

@BCerki BCerki commented Dec 20, 2024

card: https://github.com/orgs/bcgov/projects/123/views/16?pane=issue&itemId=91540613&issue=bcgov%7Ccas-registration%7C2627

Notes:

  • I've checked off the parts I've completed in the card's AC
  • I've also removed some fields that don't exist in reg2 anymore
  • If there are rebase conflicts, I think we should be able to just wipe whatever's in develop and replace with this

@BCerki BCerki changed the base branch from develop to test-data December 20, 2024 23:51
@@ -3,17 +3,14 @@
"model": "registration.operation",
"pk": "e1300fd7-2dee-47d1-b655-2ad3fd10f052",
"fields": {
"point_of_contact": 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got errors when I removed this, but I don't think it's supposed to be used in reg2, to investigate

Base automatically changed from test-data to develop December 24, 2024 18:08
@fviduya fviduya force-pushed the 2627-improve-mock-data branch 2 times, most recently from 71331c3 to 7c9a410 Compare December 31, 2024 22:44
@fviduya fviduya force-pushed the 2627-improve-mock-data branch from 0c1835a to ea5c67a Compare January 7, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants