Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments page: verification statement logic #453

Open
2 tasks done
pbastia opened this issue Dec 17, 2024 · 2 comments
Open
2 tasks done

Attachments page: verification statement logic #453

pbastia opened this issue Dec 17, 2024 · 2 comments
Assignees
Labels
Task For work that doesn't meet the requirements of a user story

Comments

@pbastia
Copy link
Contributor

pbastia commented Dec 17, 2024

Describe the task

Right now the verification statement is required no matter what, but that logic will need to be amended to be the real one
Followup to #445

Acceptance Criteria

Given I am an industrial reporter
And my reporting circumstances require that I submit a verification statement
When I am on the Attachments page
Then I can't submit the page until I have uploaded a file in the verification statement form.

Given I am an industrial reporter
And my reporting circumstances DOES NOT require that I submit a verification statement
When I am on the Attachments page
Then I can submit the page without an uploaded a file in the verification statement form.

Development Checklist:

  • In file bciers/apps/reporting/src/app/components/attachments/AttachmentsPage.tsx implement getReportNeedsVerification() using response value for AttachmentForm prop isVerificationStatementMandatory
  • Update AttachmentPage vitest

Additional context

  • Add any other context about the task here.
  • Or here
@pbastia pbastia added Task For work that doesn't meet the requirements of a user story Backlog Refinement Tickets that require further refinement labels Dec 17, 2024
@rdromey rdromey added the Blocked This ticket is blocked by another ticket. label Dec 18, 2024
@rdromey
Copy link
Contributor

rdromey commented Dec 18, 2024

@shon-button to write dev checklist + AC

@shon-button shon-button removed the Blocked This ticket is blocked by another ticket. label Dec 19, 2024
@shon-button shon-button removed the Backlog Refinement Tickets that require further refinement label Dec 19, 2024
@shon-button shon-button self-assigned this Dec 19, 2024
@shon-button
Copy link

@patriciarussellCAS

This should be tested with release v1.18.0 - after the refactor of conditions for when to display or not addressed in PR 2625

PR Test Steps
Replace http://localhost:3000/ with https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task For work that doesn't meet the requirements of a user story
Projects
None yet
Development

No branches or pull requests

3 participants