-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 405 - refactor report needs verification logic as service #2625
Conversation
a0864aa
to
44c10ca
Compare
62e5b17
to
4768e0f
Compare
22dd9c6
to
40f409a
Compare
40f409a
to
b53df0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of nitpicks, this is excellent!!
REGULATED_OPERATION_PURPOSES = { | ||
Operation.Purposes.OBPS_REGULATED_OPERATION, | ||
Operation.Purposes.OPTED_IN_OPERATION, | ||
Operation.Purposes.NEW_ENTRANT_OPERATION, | ||
} | ||
ATTRIBUTABLE_EMISSION_THRESHOLD = Decimal('25000000') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably live in a utils or config place, it's important that the tests use the same source as the service code for these values
chore: prettier
chore: cleanup
chore: cleanup
chore: cleanup chore: cleanup chore: cleanup
Co-authored-by: Pierre Bastianelli <[email protected]>
fbfc051
to
9f8617d
Compare
Co-authored-by: Pierre Bastianelli <[email protected]> chore: implement review suggestions
5deb39e
to
284ad9e
Compare
Addresses review comments from @pbastia in PR: chore: conditional verification routing
Addresses 453
Addresses 450
🚀 Impact:
Compliance Summary
page routing,Attachment
page required field, andSign-Off
page verification statement validation onSubmit Report
🔬 Local Testing:
Test Registration Purpose = "OBPS Regulated Operation"
Operation 3
, click buttonStart
Expected Results
Review operation information
page displaysRegistration Purpose
= "OBPS Regulated Operation"Expected Results
Compliance Summary
page displaysContinue
Continue
Expected Results
Verification
page displays becauseOperation 3/Registration Purpose
= "OBPS Regulated Operation"Save & Continue
Expected Results
Verification Statement
file is mandatorySubmit Report
Expected Results
A verification statement must be uploaded with this report. Please upload a verification statement on the Attachments page.
Test Registration Purpose = "Electricity Import Operation"
Operation 14
, click buttonStart
Expected Results
Review operation information
page displaysRegistration Purpose
= "Electricity Import Operation"Continue
Expected Results
Final Review
page displays becauseOperation 14/Registration Purpose
!= ("OBPS Regulated Operation":"Opt-in"; "New Entrant") AND total emissions attributable < 25,000 TCo2Save & Continue
Expected Results
Verification Statement
file is NOT mandatorySubmit Report
Expected Results
A verification statement must be uploaded with this report. Please upload a verification statement on the Attachments page.
Optional: Test Registration Purpose = "Electricity Import Operation" total emissions attributable >=25,000 TCo2
Operation 14
, click buttonStart
Continue
Expected Results
Verification
page displays becauseOperation 14/ total emissions attributable >=25,000 TCo2
Save & Continue
Expected Results
Verification Statement
file is mandatorySubmit Report
Expected Results
A verification statement must be uploaded with this report. Please upload a verification statement on the Attachments page.