Report Data: No negative numbers in Reporting data

[patriciarussellCAS]

Describe the Bug:

Not really a bug, but rather a rule we yet to set for reporting data.

The industry users should NOT be able to type in negative numbers in any of the number fields in the annual report.

Edit: They should be able to entre a zero in required fields, however we need to confirm with the BA if there are specific fields (for example some emissions fields) that should NOT be allowed to be blank or zeros. But for now we will proceed with the ability for zeros to be entered in the system.

This has been flagged by MNP as a fix they'd like to see.

Probability: 5 (currently negative numbers are allowed in the reporting app)

(How likely the bug is to happen, scored from 1-5. For example, probability of 5 is something like "it happens to all users every time they log in." whereas probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")

Impact: 4 (due to negative numbers potentially impacting the compliance obligation total)

(How bad the bug is when it does happen, scored from 1-5. For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected." whereas effect of 1 is "It makes some styling look a little bit weird.")

Screenshots:

Additional information:

Additional Context

[pbastia]

@patriciarussellCAS were any specific forms flagged for this request?
Zeroes make sense on many forms, like

• some activities that break down by quarter or monthly
• production data
• allocation to categories that don't apply
• new entrant data

[patriciarussellCAS]

Thanks @pbastia. Going off the discussion on the SME channel we have the following info:

1. Negative numbers shouldn't be allowed, except for Lat/Long
2. We likely need to allow users to input zeros. We'll just need to justify this for the FRCR.

Comment from Robb:

We have many instances of a zero being entered where the field is N/A. I am fine with this being allowed, although it may make the database a bit cleaner if we forced them to leave values blank instead?
More a question for a data architect. It's a bit annoying to have row upon row of zeros in the data, but we can live with it.

Comment from Dylan:

There's some nuance to consider I think. The forms collecting data each work a little differently. The activity forms probably make sense to exclude zeroes since they have to explicitly add each item. Adding an emission and then entering zero there doesn't make sense. However, some forms show them things where a zero may make sense in places that we show them all fields by default(ie: allocation of emissions, electricity generation on the additional data form, etc..). Are we talking about an app-wide rule? Or should we consider these forms or set of forms separately when deciding whether a zero is allowed or not

On the allocation of emissions page, where we show them all categories & pre-populated zeroes. Any fields containing zeroes on save do not create records in the database

[Robb gave Dylan's comment a thumbs up]