Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plot_bivariate() function #200

Merged
merged 21 commits into from
Feb 14, 2024
Merged

add plot_bivariate() function #200

merged 21 commits into from
Feb 14, 2024

Conversation

cmahony
Copy link
Collaborator

@cmahony cmahony commented Feb 13, 2024

This function is now complete and ready for merge into devl.

@cmahony cmahony requested a review from CeresBarros February 13, 2024 01:28
@cmahony cmahony added the enhancement New feature or request label Feb 13, 2024
Copy link
Member

@CeresBarros CeresBarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@CeresBarros
Copy link
Member

CeresBarros commented Feb 13, 2024

@cmahony there's a test failure related to the plot_bivariate example. png(..., type = "cairo") is not readily supported in macOS systems.
I'll need to set up the GitHub Actions node differently to support PNG form macOD

Also, there's a missing import in plot_bivariate and undeclared variables -- I can fix.

@CeresBarros
Copy link
Member

note to @cmahony : pushed several fixes. Waiting for checks to pass then, if all is good, will merge :)

@codecov-commenter
Copy link

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (9037362) 84.60% compared to head (9596219) 78.57%.
Report is 11 commits behind head on devl.

❗ Current head 9596219 differs from pull request most recent head 859b035. Consider uploading reports for the commit 859b035 to get more accurate results

Files Patch % Lines
R/plot_bivariate.R 0.00% 105 Missing ⚠️
R/historic.R 87.14% 9 Missing ⚠️
R/gcm.R 93.22% 8 Missing ⚠️
R/normal.R 94.73% 2 Missing ⚠️
R/database.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             devl     #200      +/-   ##
==========================================
- Coverage   84.60%   78.57%   -6.04%     
==========================================
  Files          21       22       +1     
  Lines        1637     1806     +169     
==========================================
+ Hits         1385     1419      +34     
- Misses        252      387     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CeresBarros CeresBarros merged commit 453a91f into devl Feb 14, 2024
4 checks passed
@CeresBarros
Copy link
Member

merged but see #203

@CeresBarros CeresBarros deleted the plot_bivariate branch February 27, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants