-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match.arg
is not behaving as I thought it did
#289
Conversation
|
uhmm i see the same vignette build failing with a different error now on GHA:
|
other fixes have been added to this PR:
|
all tests seem to be passing now, except code coverage calculation -- not sure what's going on, but not serious. @cmahony before merging, could you please check that the |
approval on |
match.arg
won't error ifarg
contains entries that are not found inchoices
-- it simply excludes them. It also does a partial which may lead to selecting the wrong options (especially for variable names if the user partially writes them right.This is not the type of behaviour we want most times so I replaced many of the
match.arg
withsetdiff
-type of checks.My local checks are failing to build one of the vignettes, but I doubt that this is related to my changes - keeping this as a draft to diagnose.
Also, please note that I've added 00 to the development version numbering (it should be 9000, 9001, 9002, ..., not 90, 91, 92, ...)