Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow, pipeline, pipelinerun and tasks #34

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

kshapka-bcgov
Copy link

No description provided.

@kshapka-bcgov kshapka-bcgov force-pushed the feature/DESCW-2337-pipeline branch from 6a0d239 to d6aa204 Compare June 18, 2024 21:37
@kshapka-bcgov kshapka-bcgov marked this pull request as ready for review June 18, 2024 21:45
@mhaswell-bcgov
Copy link

The build config is still using the original NotifyBC repo right? Have we tried building using this repo?
I don't have a good understanding of the OpenShift build process. If we merge this, what will change?

@kshapka-bcgov
Copy link
Author

The build config is still using the original NotifyBC repo right? Have we tried building using this repo? I don't have a good understanding of the OpenShift build process. If we merge this, what will change?

The build config will have to be updated to point to the right image.
Once this is merged, the build config notify-bc will be triggered when changes to the src folder are merged into v5.

- name: send-to-rocketchat
params:
- name: url-secret
value: $(params.rocketchat-url-secret)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a helm value? and if so i suspect there is a follow up pr for the tenant repo!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is the name of the openshift secret that the curl task (see that file below) will look up and use. It is provided by the pipeline-run (in this case "rocketchat-url").

@kshapka-bcgov kshapka-bcgov merged commit de48c4d into v5 Jun 19, 2024
5 checks passed
@kshapka-bcgov kshapka-bcgov deleted the feature/DESCW-2337-pipeline branch August 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants