Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESCW-2428 change backup storage class to netap-file-backup #38

Merged
merged 1 commit into from
Jul 3, 2024
Merged

DESCW-2428 change backup storage class to netap-file-backup #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/templates/pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ spec:
requests:
storage: {{ .Values.cronJob.persistence.size }}
{{ end }}
storageClassName: {{ .Values.cronJob.storageClassName }}
10 changes: 5 additions & 5 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@ cronJob:
size: 5Gi
resources:
requests:
cpu: "50m"
memory: "256Mi"
cpu: '50m'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious what is converting the single to double quotes. as i'm sure we don't have a script that lints these files, and it is an influence of VS Code autosaving this. In either case we should be cautious.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgov/des-notifybc/blob/v5/.prettierrc.yml#L1

I'm not sure why they weren't single quotes in the first place.

memory: '256Mi'
limits:
cpu: "250m"
memory: "1Gi"

cpu: '250m'
memory: '1Gi'
storageClassName: netapp-file-backup

hpa:
cron:
Expand Down