Feature/dswp 59 pattern vertical card #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaswell-bcgov
previously approved these changes
Jan 3, 2025
patterns/dswp-vertical-card.php
Outdated
| <!-- /wp:paragraph --> | ||
|
|
||
| <!-- wp:paragraph {"style":{"spacing":{"margin":{"top":"0","bottom":"0"}}}} --> | ||
| <p style="margin-top:0;margin-bottom:0"><a href="https://localhost/ticorp/test2/" data-type="page" data-id="15259">Neque porro quisquam</a></p> |
There was a problem hiding this comment.
Suggested change
| <p style="margin-top:0;margin-bottom:0"><a href="https://localhost/ticorp/test2/" data-type="page" data-id="15259">Neque porro quisquam</a></p> | |
| <p style="margin-top:0;margin-bottom:0"><a href="#example" data-type="page" data-id="15259">Neque porro quisquam</a></p> |
Might be better to replace the links with something like this so at least if the user forgets to set the href it doesn't try to go to localhost.
There was a problem hiding this comment.
done, please re-approve
mhaswell-bcgov
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.