Handle undefined requestids from frontend

bcgov · Aug 20, 2024 · 9838753 · 9838753
1 parent 4233f29
commit 9838753
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/request-management-api/request_api/models/FOIRequests.py b/request-management-api/request_api/models/FOIRequests.py
@@ -123,6 +123,7 @@ def getrawrequestidbyfoirequestid(cls,requestid)->DefaultMethodResult:
                         where fr.foirequestid=:requestid
                         order by  fr."version" desc limit 1"""
             rs = db.session.execute(text(sql), {'requestid': requestid})
+            rawrequestid = None
             for row in rs:
                 rawrequestid = row["foirawrequestid"]
         except Exception as ex:

diff --git a/request-management-api/request_api/services/requestservice.py b/request-management-api/request_api/services/requestservice.py
@@ -155,6 +155,8 @@ def getrequest(self, foirequestid, foiministryrequestid):
         return requestservicegetter().getrequest(foirequestid, foiministryrequestid)
 
     def getrawrequestidbyfoirequestid(self, foirequestid):
+        if foirequestid == 'undefined':
+            return None
         rawrequestid = requestservicegetter().getrawrequestidbyfoirequestid(foirequestid)
         if rawrequestid is None:
             rawrequestid = foirequestid