Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response added in the OnHold dropdown #4740

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Response added in the OnHold dropdown #4740

merged 3 commits into from
Nov 20, 2023

Conversation

divyav-aot
Copy link
Contributor

No description provided.

@@ -1,46 +1,54 @@
import React, { useEffect, useState } from 'react';
import React, { useEffect, useState } from "react";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts for AttachmentModal.js

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

No Coverage information No Coverage information
8.3% 8.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

const personalIAO = !_isMinistryCoordinator && personalRequest;

const previousState =
stateTransition?.length > 0 && stateTransition[1]?.status;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved "previousState" to the top

_state.status.toLowerCase() !==
StateEnum.response.name.toLowerCase()
);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the onhold statelist based on previousState condition. If previousState == Response then include response else include CFR.

onhold: [
{ status: "On Hold", isSelected: false },
{ status: "Call For Records", isSelected: false },
{ status: "Response", isSelected: false },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Response in the onhold list

@divyav-aot divyav-aot merged commit 87f8eaa into dev Nov 20, 2023
2 of 3 checks passed
@divyav-aot divyav-aot deleted the dev-DV-4721 branch January 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants