Fix for Response status to show in On-Hold list #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added logs to test the paybc response
Response added in the OnHold dropdown
divyav-aot
requested review from
aparna-aot,
abin-aot,
Aman-Hundal,
antsand,
sumathi-thirumani,
richard-aot,
milosdes and
nkan-aot
divyav-aot
commented
Nov 21, 2023
| const personalIAO = !_isMinistryCoordinator && personalRequest; | ||
|
|
||
| const previousState = | ||
| stateTransition?.length > 0 && stateTransition[1]?.status; |
There was a problem hiding this comment.
declared previousState in the top to check whether it is feeestimate or response. Based on that the onhold state list will be returned.
divyav-aot
commented
Nov 21, 2023
| _state.status.toLowerCase() !== | ||
| StateEnum.response.name.toLowerCase() | ||
| ); | ||
| } |
There was a problem hiding this comment.
changed the logic of onhold state list based on previousState condition.
divyav-aot
commented
Nov 21, 2023
| return _stateList.feeassessed; | ||
| case StateEnum.onhold.name.toLowerCase(): | ||
| return _stateList.onhold; |
There was a problem hiding this comment.
removed unnecessary case for onhold
divyav-aot
commented
Nov 21, 2023
| onhold: [ | ||
| { status: "On Hold", isSelected: false }, | ||
| { status: "Call For Records", isSelected: false }, | ||
| { status: "Response", isSelected: false }, |
There was a problem hiding this comment.
added Response as part of OnHold list
Removed all logs from fee_service
|
SonarCloud Quality Gate failed.
|
richard-aot
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.