Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot 4777 fixes #5043

Merged
merged 16 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions forms-flow-web/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# base image
# FROM node:14.17.0-alpine as build-stage
FROM artifacts.developer.gov.bc.ca/docker-remote/node:14.17.0-alpine as build-stage
FROM artifacts.developer.gov.bc.ca/docker-remote/node:20.10.0-alpine as build-stage

# set working directory
WORKDIR /forms-flow-web/app
Expand Down Expand Up @@ -84,7 +84,7 @@ RUN npm install --unsafe-perm
COPY . /forms-flow-web/app/
RUN npm run build

FROM artifacts.developer.gov.bc.ca/docker-remote/nginx:1.17 as production-stage
FROM artifacts.developer.gov.bc.ca/docker-remote/nginx:1.25.3 as production-stage
RUN mkdir /app
COPY --from=build-stage /forms-flow-web/app/build /usr/share/nginx/html
COPY nginx.conf /etc/nginx/nginx.conf
Expand Down
6 changes: 3 additions & 3 deletions forms-flow-web/Dockerfile.local
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# base image
# FROM node:14.17.0-alpine as build-stage
FROM node:14.17.0-alpine as build-stage
FROM node:20.10.0-alpine as build-stage

# set working directory
WORKDIR /forms-flow-web/app
Expand Down Expand Up @@ -72,12 +72,12 @@ COPY package-lock.json /forms-flow-web/app/package-lock.json
COPY package.json /forms-flow-web/app/package.json


RUN npm install --unsafe-perm
RUN npm install
#RUN npm install [email protected] -g --silent
COPY . /forms-flow-web/app/
RUN npm run build

FROM nginx:1.17 as production-stage
FROM nginx:1.25.3 as production-stage
RUN mkdir /app
COPY --from=build-stage /forms-flow-web/app/build /usr/share/nginx/html
COPY nginx.conf /etc/nginx/nginx.conf
Expand Down
Loading
Loading