Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing join condition in query #5049

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix missing join condition in query #5049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions request-management-api/request_api/models/FOIRawRequests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,13 +1108,13 @@ def getunopenedunactionedrequests(cls, startdate, enddate):
select max(version) as version, requestid from public."FOIRawRequests"
group by requestid
) mv on mv.requestid = rr.requestid and mv.version = rr.version
join (
left join (
select request_id, max(payment_id) from public."Payments"
where fee_code_id = 1
group by request_id
order by request_id
) mp
join public."Payments" p on p.payment_id = mp.max
) mp on mp.request_id = rr.requestid
left join public."Payments" p on p.payment_id = mp.max
where status = 'Unopened' and rr.version = 1 and created_at > :startdate and created_at < :enddate
order by rr.requestid '''
rs = db.session.execute(text(sql), {'startdate': startdate, 'enddate': enddate})
Expand Down
Loading