Added RTT tag and notification for RTT attachments #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to handle the observations of 3090, 3092, 3093, 3085.
|
antsand
changed the title
milosdes
approved these changes
Apr 15, 2024
divyav-aot
reviewed
Apr 16, 2024
| eventservice().attachmentevent(ministryrequestid, document, userid, "add", message) | ||
| #if 'rrt' in documentschema['documents']['category']: | ||
| #Create notification event for RRT document | ||
| # eventservice().posteventforextension(ministryrequestid, '', userid, '' , "add") | ||
| return FOIMinistryRequestDocument.createdocuments(ministryrequestid, version, documentschema['documents'], userid) |
There was a problem hiding this comment.
keep the RRT related changes to events/attatment.py
Also, call the attachmentevent from the resource level(POST)
divyav-aot
reviewed
Apr 16, 2024
| return "Attachment Upload Event" | ||
|
|
||
| def __defaultuserid(self): | ||
| return "System" |
There was a problem hiding this comment.
remove unnecessary codes or functions.
prepare the notification and comments message here.
include createcomment() also.
There was a problem hiding this comment.
Also, make sure to include scanning team members as discussed. The changes should be done in services\notifications\notificationuser.py
divyav-aot
reviewed
Apr 16, 2024
| if attachmenteventresponse.success == False: | ||
| current_app.logger.error("FOI Notification failed for event for attachment= %s" % (document['category'])) | ||
| except BusinessException as exception: | ||
| self.__logbusinessexception(exception) |
There was a problem hiding this comment.
update it as async event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.