[FOIMOD-3104] Requests Queues Bug Fix

[JieunSon96]

FOIMOD-3104

• This query utilizes a subquery to select distinct records based on foiministryrequest_id, grouping by foiministryrequestversion_id. It then returns the maximum outcomeid if all outcomeid values are non-null; otherwise, it returns null. This ensures that we capture unique records while accurately reflecting the status of the outcomeid field.

[richard-aot]

Looks like you want to get requests whose outcomeid ever appears null value. If that's the case, is it possible to just query outcomeid is null in the subquery, instead compare count(outcomeid) = count(*)? That might be more efficient.

[JieunSon96]

Looks like you want to get requests whose outcomeid ever appears null value. If that's the case, is it possible to just query outcomeid is null in the subquery, instead compare count(outcomeid) = count(*)? That might be more efficient.

Yes I also agree for more efficiency I also think it is better to remove the count function because it needs more computations all over records so changed simply checking for NULL and selecting the maximum value instead.

SELECT DISTINCT ON (foiministryrequest_id) foiministryrequest_id, foiministryrequestversion_id, CASE WHEN EXISTS (SELECT 1 FROM "FOIRequestOIPC" WHERE fo.foiministryrequest_id = foiministryrequest_id AND fo.foiministryrequestversion_id = foiministryrequestversion_id AND outcomeid IS NULL) THEN NULL ELSE MAX(outcomeid) END AS outcomeid FROM "FOIRequestOIPC" fo GROUP BY foiministryrequest_id, foiministryrequestversion_id ORDER BY foiministryrequest_id, foiministryrequestversion_id DESC;

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud