Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOIMOD-3389] add generic cover email template #5355

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

JieunSon96
Copy link
Collaborator

@JieunSon96 JieunSon96 commented Aug 9, 2024

FOIMOD-3389

  • Add a generic cover email template with revision.
  • Add a generic HTML cover email template on all states.
  • Removed unused console log.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Comment on lines 1028 to 1031
requestState !== StateEnum.intakeinprogress.name &&
requestState !== StateEnum.unopened.name &&
requestState !== StateEnum.open.name &&
//requestState !== StateEnum.open.name &&
requestState !== StateEnum.appfeeowing.name &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want the communication tab available in all of these states.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right! The visibility of this in other states will be handled in a different ticket story, considering any other template options that may be possible based on the state and other criteria. So for now, I made sure that this template is always visible only in states beyond 'Open'.

Comment on lines +35 to +37
if (requestDetails.currentState === "Open") {
return "NA";
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need to do this for the other 3 states (intake in progress, unopened, app fee owing)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! we need to show the OIPC and PB templates in states beyond 'Open', so it seems like a necessary addition.

@JieunSon96 JieunSon96 merged commit bebe45f into dev-marshal Aug 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants