-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FOIMOD-3389] add generic cover email template #5355
Conversation
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
requestState !== StateEnum.intakeinprogress.name && | ||
requestState !== StateEnum.unopened.name && | ||
requestState !== StateEnum.open.name && | ||
//requestState !== StateEnum.open.name && | ||
requestState !== StateEnum.appfeeowing.name && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want the communication tab available in all of these states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes right! The visibility of this in other states will be handled in a different ticket story, considering any other template options that may be possible based on the state and other criteria. So for now, I made sure that this template is always visible only in states beyond 'Open'.
if (requestDetails.currentState === "Open") { | ||
return "NA"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need to do this for the other 3 states (intake in progress, unopened, app fee owing)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! we need to show the OIPC and PB templates in states beyond 'Open', so it seems like a necessary addition.
FOIMOD-3389