Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GWELLS-2011] FEATURE** Create file count in database for searching #2057

Merged
merged 13 commits into from
Nov 20, 2023

Conversation

LocalNewsTV
Copy link
Contributor

@LocalNewsTV LocalNewsTV commented Nov 17, 2023

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change

Description

Follow up Actions

  • Check the database in Test environment to ensure that the changes took effect on the existing database by comparing these two queries
    • select COUNT(*) from well_attachment_count;
    • select COUNT(*) from well;
  • Verify counts update correctly when a file is uploaded / deleted
    • select * from well_attachment_count where well_tag_number_id = <WELLID MODIFIED IN TEST>;

This PR includes the following proposed change(s):

Backend

  • Created Well_Attachments_Count table + model.
    • updated fixture files seed data to include the new table in creation.
    • created new migrations to populate existing wells with new table.
  • Created new protected endpoint to take in the increment decrement calls for updating counts.

Frontend

  • Added calls to new endpoint on success of file upload / deletion.

Docker

  • Fixed minio-private container to populate properly in local dev environment.
  • Added health check to database, to ensure its up and running before backend starts.
  • added pgadmin container to docker-compose for local developments.

@LocalNewsTV LocalNewsTV changed the title Gwells 2011 attachments linking [GWELLS-2011] FEATURE** Create file count in database for searching Nov 17, 2023
@LocalNewsTV LocalNewsTV marked this pull request as ready for review November 17, 2023 22:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LocalNewsTV LocalNewsTV merged commit 1c6418c into release Nov 20, 2023
3 checks passed
@LocalNewsTV LocalNewsTV deleted the gwells-2011-attachments-linking branch November 20, 2023 16:01
@LocalNewsTV LocalNewsTV restored the gwells-2011-attachments-linking branch November 20, 2023 18:48
@LocalNewsTV LocalNewsTV deleted the gwells-2011-attachments-linking branch November 20, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants