Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gwells 2112 gwpr validation latest #2151

Closed
wants to merge 20 commits into from
Closed

Gwells 2112 gwpr validation latest #2151

wants to merge 20 commits into from

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Feb 9, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • { List all the changes made }
  • { Include any screenshots necessary }

fergmac added 20 commits February 2, 2024 14:46
@fergmac
Add Groundwater Protection Regulation validation
322ad32
@fergmac
Update validation.
64deefe
@fergmac
Add trailing asterisks for mandatory well class fields.
ae1e9bd
@fergmac
Add check for empty start date.
db57304
@fergmac
Create helper method for well identification plate validation.
88704e1
@fergmac
Well class fields updating.
dd856b7
@fergmac
Move date logic to parent component.
b019924
@fergmac
Remove commented code.
baa4b01
@fergmac
Add trailing asterisk for well owner fields.
7e10c0b
@fergmac
Update new well date cases.
f13edca
@fergmac
Remove unneeded code.
71aa12f
@fergmac
Uncomment check for form changes. Remove comment and console.log.
f636a48
@fergmac
Pull UTC date getter out into helper.
5bbfc4b
@fergmac
clean up.
4d0fdf1
@fergmac
Removing dewatering validation.
15cfb69
@fergmac
Add JSDoc headers. Update constants. Clean up unused code.
c7170a7
@fergmac
Add line to file.
242d6d7
@fergmac
Wrap early returns.
8a05d32
@fergmac
Clean up.
7ea53f5
@fergmac
DRYing up validation.
7cd4b7c
@fergmac fergmac self-assigned this Feb 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fergmac fergmac closed this Feb 9, 2024
@fergmac fergmac deleted the gwells-2112-gwpr-validation-latest branch February 9, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fergmac fergmac

Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fergmac @bcgov-csnr-cd