Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Change] [GWELLS-#2218] Well Submission Defaults to Single Page #2246

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[Change] [GWELLS-#2218] Well Submission Defaults to Single Page #2246

merged 1 commit into from
Jun 18, 2024

Conversation

lunamoonmoon
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Changed formIsFlat value in SubmissionsHome.vue from false (multi-page) to true (single-page) for default on load
    Screenshot 2024-06-11 at 3 46 33 PM

@lunamoonmoon lunamoonmoon requested review from DerekRoberts and a team as code owners June 11, 2024 22:48
@lunamoonmoon lunamoonmoon removed the request for review from DerekRoberts June 11, 2024 22:49
DerekRoberts
DerekRoberts approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the smallest PR I've approved today. :D

@lunamoonmoon lunamoonmoon linked an issue Jun 12, 2024 that may be closed by this pull request
Make "single page" rather than "multiple page" as default on the Well Report Submission page #2218
Closed
@lunamoonmoon
Copy link
Contributor Author

Changes to the UI making single page default affected the test's "triggers confirmation box" ability to pass for unknown reasons. Ticket 2141 plans to rebuild test suite.

@lunamoonmoon lunamoonmoon merged commit 323eda1 into release Jun 18, 2024
2 of 4 checks passed
@lunamoonmoon lunamoonmoon deleted the luna/fixsinglepage branch June 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV approved these changes

@DerekRoberts DerekRoberts DerekRoberts approved these changes

Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "single page" rather than "multiple page" as default on the Well Report Submission page
3 participants
@lunamoonmoon @DerekRoberts @LocalNewsTV