Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASPER-219: Create the connection between JASPER and the PCSS APIs #126

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

ronaldo-macapobre
Copy link

Pull Request for JIRA Ticket: JASPER-219

Issue ticket number and link

https://jag.gov.bc.ca/jira/browse/JASPER-219

Description

  • Auto generate and replaced PCSS Service Clients and Models using NSWag.
  • Import relevant code from the most recent "Calendar" branch that was backed out.
  • Initial work to make httpClient setup configurable so that it forwards requests to APIG if provided or directly connect to BC Gov API.
  • Added sonarcloud config to minimize sonarcloud issues when creating PR.
  • Fixed filtering issues with Location, Presider and Activities.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally
  • Deployed and tested branch in DEV environment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Ronaldo Macapobre added 2 commits January 3, 2025 23:36
- Make httpClient setup configurable so that it forwards requests to APIG if provided or directly connect to BC Gov API but commented for now
- Removed existing unused POCOs in PCSS
- Updated PCSS Services Clients to use generated code from NSWag.
- Import POCOs used by PCSS endpoints generated from NSWag.
- Added CourtCalendar and JudicialCalendar POCOs manually.
- Added sonarcloud config to minimize sonarcloud issues when creating PR.
@ronaldo-macapobre ronaldo-macapobre changed the title [DRAFT] JASPER-219: Create the connection between JASPER and the PCSS APIs JASPER-219: Create the connection between JASPER and the PCSS APIs Jan 4, 2025
@ronaldo-macapobre ronaldo-macapobre marked this pull request as ready for review January 4, 2025 01:22
Copy link

sonarqubecloud bot commented Jan 5, 2025

@JTraill
Copy link

JTraill commented Jan 9, 2025

Will be merging this later today

@JTraill JTraill merged commit fdc52b3 into master Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants