Code Review Feedback

* Remove disabling of filters on compliance reports
bcgov · Jan 7, 2025 · 23bb835 · 23bb835
1 parent 406d5d3
commit 23bb835
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/frontend/src/views/Admin/AdminMenu/components/__tests__/UserActivity.test.jsx b/frontend/src/views/Admin/AdminMenu/components/__tests__/UserActivity.test.jsx
@@ -83,9 +83,13 @@ describe('UserActivity', () => {
     // Optionally check the logic of getRowId
     // This is a unit-style check; you can do something like:
     const mockParams = {
-      data: { transactionType: 'AdminAdjustment', transactionId: '123' }
+      data: {
+        transactionType: 'AdminAdjustment',
+        transactionId: '123',
+        actionTaken: 'CREATE'
+      }
     }
-    expect(gridProps.getRowId(mockParams)).toBe('adminadjustment-123')
+    expect(gridProps.getRowId(mockParams)).toBe('CREATE-AdminAdjustment-123')
 
     // 5) defaultColDef
     expect(gridProps.defaultColDef).toBeDefined()

diff --git a/frontend/src/views/ComplianceReports/ComplianceReports.jsx b/frontend/src/views/ComplianceReports/ComplianceReports.jsx
@@ -87,8 +87,6 @@ export const ComplianceReports = () => {
 
   const defaultColDef = useMemo(
     () => ({
-      floatingFilter: false,
-      filter: false,
       cellRenderer: LinkRenderer,
       cellRendererParams: {
         url: (data) =>