Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1509: Fuels for other use and Export fuels not saving #1561

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Dec 23, 2024

The issue affecting the row to be saved was fixed with this commit. The root cause was the use of a non-existent function name, get_fuel_category_by_name.

Howerver, other issues were affecting the functionality of Other Use and Export fuels:

  • When selecting fuel type and there is only one fuel category, then preselect the value. Otherwise, show the values in the dropdown to allow selection.
  • When updating the fuel type, the user needs to select the option for Determining Carbon intensity
  • When modifying existing rows, quantity field should not be reset to 0

Copy link

github-actions bot commented Dec 23, 2024

Frontend Test Results

  1 files  ±0  119 suites  ±0   40s ⏱️ ±0s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 147a234. ± Comparison against base commit 04035e3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 23, 2024

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 50s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 147a234. ± Comparison against base commit 04035e3.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@areyeslo areyeslo force-pushed the LCFS-1509-OtherUse-Exports branch from 2aecef2 to 147a234 Compare December 30, 2024 19:03
@areyeslo areyeslo merged commit 64b5b3d into release-0.2.0 Dec 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants