Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improve Accessibility for AG Grid Filtering Components #1576

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

prv-proton
Copy link
Collaborator

@prv-proton prv-proton commented Jan 2, 2025

#1290
Created two new components for Date and Select filters to be inline with requirements posted in #1290. But would like the UI/UX user to test this before it is applied across. May need a follow up ticket or scale this task with extra points.

Copy link

github-actions bot commented Jan 2, 2025

Frontend Test Results

  1 files  ±0  119 suites  ±0   40s ⏱️ -1s
411 tests ±0  391 ✅ ±0  20 💤 ±0  0 ❌ ±0 
413 runs  ±0  393 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit bc10b05. ± Comparison against base commit 53ad496.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 2, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 50s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bc10b05. ± Comparison against base commit 53ad496.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets add some tests if we decide to roll this out to all the other tables after UI/UX review.

@prv-proton prv-proton merged commit ddac6d8 into release-0.2.0 Jan 2, 2025
1 check passed
@prv-proton prv-proton deleted the feat/prashanth-ag-grid-accblty-1290 branch January 2, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants