fix: compliance report fuel supply end use logic #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-hashimoto
changed the title
dhaselhan
reviewed
Jan 3, 2025
| } | ||
| } | ||
|
|
||
| if (params.column.colId === 'fuelCategory') { |
There was a problem hiding this comment.
Do you think its cleaner for column specific logic to live in a value setter or value getter for that column rather than a big if else in handle cell changed? I believe we kinda have a mix of both.
There was a problem hiding this comment.
Yea I was debating this as well. The thing I don't like about ag grid is that they don't provide a clean validation schema that's separated from row/column/cell logic. I'm going to look to rework some of this logic in a refactor ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: will need to add the new seed values to migration in #1503 pr: #1565