feat: Switch from handleRowClicked to defaultColumn #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Jan 3, 2025
•
dhaselhan
commented
- Set linkCell Renderer and link props on default column and remove row click.
- Update cell renderers to support links if present
- Apply to lots of tables
- Move test files to be closer to their components
dhaselhan
force-pushed
the
feat/daniel-cell-links-1533
branch
from
18ec1ec to
9ed3d9c
Compare
prv-proton
reviewed
Jan 3, 2025
|
|
||
| const defaultColDef = useMemo( | ||
| () => ({ | ||
| floatingFilter: false, |
There was a problem hiding this comment.
should we be disabling floating filter here?
There was a problem hiding this comment.
Good catch, definitely not. Removed and double checked the other changes to make sure I didnt accidentally turn them off elsewhere.
prv-proton
requested changes
Jan 3, 2025
* Set linkCell Renderer and link props on default column and remove row click. * Update cell renderers to all support links if present * Apply to lots of tables * Move test files to be closer to their components
* Remove disabling of filters on compliance reports
dhaselhan
force-pushed
the
feat/daniel-cell-links-1533
branch
from
a96a64f to
1e3e2a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.