Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCFS-1540: Filtering by Submitted Status on Compliance Reports results in 500 #1596

Closed
wants to merge 2 commits into from
Closed

LCFS-1540: Filtering by Submitted Status on Compliance Reports results in 500 #1596

wants to merge 2 commits into from

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Jan 3, 2025 •
edited
Loading

Fixes:

  • Handle list for Submitted when filter_type is set.
  • Show ReAssessed status.

Recommended by Manager with IDIR:
image

Recommended by Manager with BCeID:
image

ReAssessed:
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  121 suites  ±0   41s ⏱️ ±0s
419 tests ±0  399 ✅ ±0  20 💤 ±0  0 ❌ ±0 
421 runs  ±0  401 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit c771011. ± Comparison against base commit 6e12d3b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 44s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c771011. ± Comparison against base commit 6e12d3b.

♻️ This comment has been updated with latest results.

@prv-proton prv-proton self-requested a review January 3, 2025 23:19
prv-proton

This comment was marked as resolved.

Sign in to view

prv-proton

This comment was marked as outdated.

Sign in to view

prv-proton
prv-proton requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check working of other statuses for IDIR user?
image
image

@areyeslo
Copy link
Collaborator Author

areyeslo commented Jan 3, 2025

Closing this PR. Work was included in this PR

@areyeslo areyeslo closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prv-proton prv-proton prv-proton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@areyeslo @prv-proton