feat: Filter between legacy and not legacy fuel types #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Jan 3, 2025
dhaselhan
commented
- Pass compliance period for get other use table options
- Add filter on compliance period < 2024 to enable the is_legacy filter.
- Add new is_legacy to FuelTypes and default to false
AlexZorkin
requested changes
Jan 4, 2025
| """Get all table options""" | ||
| fuel_categories = await self.fuel_code_repo.get_fuel_categories() | ||
| fuel_types = await self.fuel_code_repo.get_formatted_fuel_types() | ||
| fuel_types = await self.fuel_code_repo.get_formatted_fuel_types( | ||
| include_legacy=compliance_period < "2024" |
There was a problem hiding this comment.
Let's create a constant for "2024" and call it LEGISLATION_TRANSITION_YEAR or something like that. Add a comment to the constant explaining what its for and then use this throughout the backend wherever we need to differentiate on this cutoff.
| @@ -164,6 +164,10 @@ async def get_fuel_export_table_options(self, compliancePeriod: str): | |||
| ) | |||
| ) | |||
|
|
|||
| include_legacy = compliance_period < "2024" | |||
There was a problem hiding this comment.
use constant as suggested above, and do the same for any other uses of the year.
dhaselhan
force-pushed
the
feat/daniel-add-is-legacy-1550
branch
2 times, most recently
from
57021b8 to
fe52b18
Compare
* Pass compliance period for get other use table options * Add filter on compliance period < 2024 to enable the is_legacy filter. * Add new is_legacy to FuelTypes and default to false
* Use constant for 2024
dhaselhan
force-pushed
the
feat/daniel-add-is-legacy-1550
branch
from
b9260b5 to
d641a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.