Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1553: BUG - Other diesel #1604

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Jan 4, 2025

Changes:

  • Rename other diesel for other diesel fuel in fuel types for all the schedules.
  • Allocation agreement is showing Prescribed carbon intensity - section 19 (a) which is related to fossil derived. Change to Default carbon intensity - section 19 (b) (ii) as the other schedules.

image

Copy link

github-actions bot commented Jan 4, 2025

Frontend Test Results

  1 files  ±0  121 suites  ±0   41s ⏱️ -1s
419 tests ±0  399 ✅ ±0  20 💤 ±0  0 ❌ ±0 
421 runs  ±0  401 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 97194f3. ± Comparison against base commit 88a4bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 4, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 47s ⏱️ +5s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 97194f3. ± Comparison against base commit 88a4bd3.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo requested a review from AlexZorkin January 4, 2025 17:38
@areyeslo areyeslo added bug Something isn't working Critical Ticket is critical and top priority labels Jan 6, 2025
Copy link
Collaborator

@hamed-valiollahi hamed-valiollahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@areyeslo areyeslo merged commit 9e2a069 into release-0.2.0 Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical Ticket is critical and top priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants