Fix: Add Decimal Formatting to Units and Cost - 1529 #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areyeslo
reviewed
Jan 7, 2025
| @@ -22,10 +23,12 @@ export const TransferDetails = () => { | |||
| register, | |||
| control, | |||
| watch, | |||
| formState: { errors } | |||
| formState: { errors }, | |||
| setValue | |||
There was a problem hiding this comment.
Nice catch! We don't really need it.
areyeslo
reviewed
Jan 7, 2025
| @@ -14,6 +14,7 @@ import { Controller, useFormContext } from 'react-hook-form' | |||
| import { useTranslation } from 'react-i18next' | |||
| import { LabelBox } from './LabelBox' | |||
| import { calculateTotalValue } from '@/utils/formatters' | |||
| import { NumericFormat } from 'react-number-format' | |||
There was a problem hiding this comment.
Is the formatter formatNumberWithCommas not good for formatting in Transfers? Just thinking on the overhead of updating dependencies when updating React library. If we have an existing formatter, I would prefer using it.
There was a problem hiding this comment.
I see! that was my initial thought to use number formatters to achieve it, but I faced issues with form validation and conversion, which is why I decided to go with a new solution.
Thanks, Arturo, for the code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper decimal formatting for large numbers in transfers to improve readability.
Closes #1529