Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding enter key functionality to select editor in ag-grid. #1715

Merged

Conversation

prv-proton
Copy link
Collaborator

Fix for selector component in ag-grid:
This fix adds the functionality to open/close the drop down using Enter key
#1585 (comment)

Copy link

github-actions bot commented Jan 16, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 44s ⏱️ +3s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4e583f1. ± Comparison against base commit 1c5baaf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 16, 2025

Frontend Test Results

  1 files  ±0  123 suites  ±0   44s ⏱️ -1s
429 tests ±0  409 ✅ ±0  20 💤 ±0  0 ❌ ±0 
431 runs  ±0  411 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 4e583f1. ± Comparison against base commit 1c5baaf.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@prv-proton prv-proton merged commit 582ffa8 into release-0.2.0 Jan 16, 2025
11 checks passed
@prv-proton prv-proton deleted the fix/prashanth-accessibility-select-editor-1585 branch January 16, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants