Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migrate Notional Transfer Records with Version Chaining - 1555 #1752

Merged

Conversation

hamed-valiollahi
Copy link
Collaborator

This PR implements the migration of notional transfer records from TFRS to LCFS, including version chaining.

Closes #1555

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, looking forward to testing this out. ty 👍

For the registry files, please pull release and update before merging.

Copy link

Frontend Test Results

  1 files  ±0  123 suites  ±0   43s ⏱️ ±0s
429 tests ±0  409 ✅ ±0  20 💤 ±0  0 ❌ ±0 
431 runs  ±0  411 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 22e78b3. ± Comparison against base commit 2475b91.

Copy link

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 50s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 22e78b3. ± Comparison against base commit 2475b91.

@hamed-valiollahi
Copy link
Collaborator Author

Looks great, looking forward to testing this out. ty 👍

For the registry files, please pull release and update before merging.

Sure, thank you for reviewing my PR, Alex!

@hamed-valiollahi hamed-valiollahi merged commit 323efdf into release-0.2.0 Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCFS - Migrate Schedule A Records from TFRS to Notional Transfers in LCFS with Version Chaining
2 participants